Repository navigation
Conversation
…e guidance When `ng update` aborts because a package uses the `catalog:` protocol, the manual migration steps hardcode pnpm and yarn: the install step suggests 'pnpm install' for every package manager except yarn, and the catalog file hint only names pnpm-workspace.yaml and .yarnrc.yml. Bun workspaces also support catalogs, so a bun workspace is told to run 'pnpm install' and to look for files it does not have. Build the install command from the detected package manager and name the catalog location it actually uses: pnpm-workspace.yaml for pnpm, .yarnrc.yml for yarn, and the 'workspaces.catalog' field in the root package.json for bun. The previous generic text is kept as a fallback when the package manager is unknown. The new spec fails without the fix: with `packageManager: 'bun'`, the guidance suggested 'pnpm install' and the pnpm/yarn file names.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the catalog update guidance in the Angular CLI update resolver to dynamically reference the correct configuration file and install command based on the active package manager (such as pnpm, yarn, or bun). It also adds a unit test to verify this behavior when using 'bun' as the package manager. I have no additional feedback to provide as the changes are well-implemented and covered by tests.
Collaborator
|
Thank you for your contribution. We are closing this PR for a couple of reasons:
Since the current message already uses |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
ng updateaborts because a package uses thecatalog:protocol, the manual migration steps hardcode pnpm and yarn: the install step suggests 'pnpm install' for every package manager except yarn, and the catalog file hint only names pnpm-workspace.yaml and .yarnrc.yml. Bun workspaces also support catalogs, so a bun workspace is told to run 'pnpm install' and to look for files it does not have.Build the install command from the detected package manager and name the catalog location it actually uses: pnpm-workspace.yaml for pnpm, .yarnrc.yml for yarn, and the 'workspaces.catalog' field in the root package.json for bun. The previous generic text is kept as a fallback when the package manager is unknown.
The new spec fails without the fix: with
packageManager: 'bun', the guidance suggested 'pnpm install' and the pnpm/yarn file names.